Re: Patch to contribute in pgAdmin to increase the maximum length ofthe server password - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Patch to contribute in pgAdmin to increase the maximum length ofthe server password
Date
Msg-id CANxoLDdFt85cpQzsNrx7DKNaGkgynysabLA5LnJaJZaYoReihg@mail.gmail.com
Whole thread Raw
In response to Re: Patch to contribute in pgAdmin to increase the maximum length ofthe server password  (Mishika Singh <mishikaps@gmail.com>)
List pgadmin-hackers
Thanks, patch applied.

On Mon, Jun 15, 2020 at 4:28 PM Mishika Singh <mishikaps@gmail.com> wrote:
Hi Aditya,

I am part of Adobe Experience Platform - Query Service team. Query Service uses the Postgres protocol to query data in Platform. We have enabled a variety of client applications to connect to Query Service like Aqua Data Studio, Power BI, Tableau. [https://docs.adobe.com/content/help/en/experience-platform/query/clients/overview.html]
Length of the password to connect to query service is more than 1000 characters. 


On Mon, Jun 15, 2020 at 3:55 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Mishika,

The patch looks good to me. Just out of curiosity, what is the use case where the password is more than 1000 characters ? :O

On Mon, Jun 15, 2020 at 3:41 PM Mishika Singh <mishikaps@gmail.com> wrote:
Thanks Aditya for looking into this. I have done the changes noting
your suggestion to pass the maxLength param for the password field.
PFA of the patch for the same.

On Mon, Jun 8, 2020 at 11:41 AM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Mishika,
>
> You've changed the defaults directly which will change the maxLength for all the text boxes across pgAdmin.
> If you want to change the maxLength for the server dialog password field then you can pass the maxLength param for the password field. This will affect the password field only without affecting others.
>
>
> On Mon, Jun 8, 2020 at 12:46 AM Mishika Singh <mishikaps@gmail.com> wrote:
>>
>> Hi Team,
>>
>> I have created an issue :https://redmine.postgresql.org/issues/5592.
>> In pgAdmin4 there is a restriction on the password length while trying
>> to connect to the server, the limit is 255. We have use cases where
>> the password length is more than that.
>>
>> PFA of the patch to increase the maximum length.
>>
>> --
>> Regards
>> Mishika Singh
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"



--
Regards

Mishika Singh


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Regards
Mishika Singh


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: Reg - [sonarqube] Refactor this code so that this expression doesnot always evaluate to true
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube