Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working
Date
Msg-id CANxoLDciA484H5RMwbL3Nn+PudGFYxa_jjRnQnXsmYoPeOKxQw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working  (Dave Page <dave.page@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Aditya

Below are my review comments:
  • You have added new config parameter "DISABLE_BEFOREUNLOAD_MESSAGE" to make this request configurable, should it be the part of preferences setting instead of configuration? @Dave can you please comment on this.
  • Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not clear as users perspective, can you please change it to some meaningful name.
Apart from that code looks good to me.  

On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to throw alert warning when user reloads or closes the browser. 

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields
Next
From: Murtuza Zabuawala
Date:
Subject: Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields