Postgres Pro
Downloads
Home   >   mailing lists

Re: Resql test cases for views and fix for bug: 4650 - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Resql test cases for views and fix for bug: 4650
Date
Msg-id CANxoLDch-vX4MydVUrq3aC8Y4=vTrw0M_-YOgjpdDP0heVLQow@mail.gmail.com
Whole thread Raw
In response to Re: Resql test cases for views and fix for bug: 4650  (Usman Muzaffar <usman.muzaffar@enterprisedb.com>)
Responses Re: Resql test cases for views and fix for bug: 4650  (Usman Muzaffar <usman.muzaffar@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Usman

I have modified the code, please work on the following test cases:
  • No test case for privileges at all.
  • We should add alter test cases for check_option, security_barrier and privileges.
Attached is the modified patch, please continue your work on it. 

On Tue, Aug 27, 2019 at 12:12 PM Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:
Just a correction, bug reference in above mail should be 4486 instead of 4650.

On Mon, Aug 26, 2019 at 7:50 PM Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:
Hi Hackers,

Please find here attached patch for sql re engineering test cases for views node. As part of this patch I have also incorported followings
  • Fix for bug # 4650
  • Also modified views/template/create.sql due to which, apparently same output and input was not matching for test cases.
Following are verified before sending the patch
  • yarn run pep8
  • verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and ppas 9.4 to 11.

--


Thanks,

Usman Muzaffar
QA Team
EnterpriseDB Corporation


--


Thanks,

Usman Muzaffar
QA Team
EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Usman Muzaffar
Date:
Subject: Re: Resql test cases for views and fix for bug: 4650
Next
From: Shubham Agarwal
Date:
Subject: Re: pgAdmin4 Feature Tests intermittent failures fix