On Thu, Jan 21, 2021 at 2:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi RahulFollowing are the review comments:Change the name of the function 'get_pg_db_properties'. The function returns lastsysoid and datistemplate only and I assume it is applicable for PG/EPAS both. Done!Add comments for all the new functions introduce in the patch. Added!On Thu, Jan 21, 2021 at 2:36 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch which resolves the sonar qube issues relating:Foreign Tables -Refactor this function to reduce its Cognitive Complexity from 67 to the 15 allowed.Database -Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.-- Rahul ShirsatSenior Software Engineer | EnterpriseDB Corporation.-- Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246-- Rahul ShirsatSenior Software Engineer | EnterpriseDB Corporation.
Hi RahulFollowing are the review comments:Change the name of the function 'get_pg_db_properties'. The function returns lastsysoid and datistemplate only and I assume it is applicable for PG/EPAS both.
Add comments for all the new functions introduce in the patch.
On Thu, Jan 21, 2021 at 2:36 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch which resolves the sonar qube issues relating:Foreign Tables -Refactor this function to reduce its Cognitive Complexity from 67 to the 15 allowed.Database -Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.-- Rahul ShirsatSenior Software Engineer | EnterpriseDB Corporation.-- Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246
Hi Hackers,Please find the attached patch which resolves the sonar qube issues relating:Foreign Tables -Refactor this function to reduce its Cognitive Complexity from 67 to the 15 allowed.Database -Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.-- Rahul ShirsatSenior Software Engineer | EnterpriseDB Corporation.
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных