Postgres Pro
Downloads
Home   >   mailing lists

Re: SonarQube Fixes #4 Database & Foreign Tables - Mailing list pgadmin-hackers

From Rahul Shirsat
Subject Re: SonarQube Fixes #4 Database & Foreign Tables
Date
Msg-id CAKtn9dN2O-g-PwKT8qYaAqMS3ohkZ76JpvBPSR2_qnQ7Tjsarg@mail.gmail.com
Whole thread Raw
In response to Re: SonarQube Fixes #4 Database & Foreign Tables  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: SonarQube Fixes #4 Database & Foreign Tables
List pgadmin-hackers
Tree view


On Thu, Jan 21, 2021 at 2:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Rahul

Following are the review comments:
  • Change the name of the function 'get_pg_db_properties'. The function returns lastsysoid and datistemplate only and I assume it is applicable for PG/EPAS both.
 Done!
  • Add comments for all the new functions introduce in the patch.
 Added!

On Thu, Jan 21, 2021 at 2:36 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch which resolves the sonar qube issues relating:

  1. Foreign Tables -Refactor this function to reduce its Cognitive Complexity from 67 to the 15 allowed.
  2. Database -Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.
Attachment

pgadmin-hackers by date:

Previous
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin][RM1802] ERD Tool (Beta)
Next
From: Nidhi Bhammar
Date:
Subject: [pgAdmin][RM6147] - Kerberos documentation