Re: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed
Date
Msg-id CANxoLDc+J1qQJ=YuaKLrkQz=_5PYbLFHZ0YOw1c3u3vd=+L+4A@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi All 

On Fri, Oct 28, 2016 at 8:53 PM, Dave Page <dpage@pgadmin.org> wrote:


On Fri, Oct 28, 2016 at 10:23 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All

Please find the attached patch to fix the RM #1729 Role privileges are badly displayed

Please review it.

Hi

This improves the display on the properties dialogue, though it could still make much better use of the space (for example, the switches could almost be right-justified). However, it messes up the Properties pane on the browser, as it shows the switches indented compared to other controls.

   Attached is the modified patch as per Dave's suggestion. Please review it.  

Thanks. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: Re: PATCH: To fix the issue in constraints node (pgAdmin4)
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix display of exclusion contraint dependencies. Part