Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed
Date
Msg-id CA+OCxoxfnsFeoJ0QRxfiBCFR5d6e05_EDr0Z567LV7T38Mfy8w@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied.

On Tuesday, November 1, 2016, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All 

On Fri, Oct 28, 2016 at 8:53 PM, Dave Page <dpage@pgadmin.org> wrote:


On Fri, Oct 28, 2016 at 10:23 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All

Please find the attached patch to fix the RM #1729 Role privileges are badly displayed

Please review it.

Hi

This improves the display on the properties dialogue, though it could still make much better use of the space (for example, the switches could almost be right-justified). However, it messes up the Properties pane on the browser, as it shows the switches indented compared to other controls.

   Attached is the modified patch as per Dave's suggestion. Please review it.  

Thanks. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Improve display of role options. Fixes #1729
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixes #1909 Handle startup errors more gracefully in