Re: BUG #19450: Where is checksum_block.inc.c after master install? - Mailing list pgsql-bugs

From John Naylor
Subject Re: BUG #19450: Where is checksum_block.inc.c after master install?
Date
Msg-id CANWCAZbbegtd55eA7DwkkSAHPHyh4x-ZR=JyuLr37ZOD56h_8A@mail.gmail.com
Whole thread
In response to Re: BUG #19450: Where is checksum_block.inc.c after master install?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #19450: Where is checksum_block.inc.c after master install?
List pgsql-bugs
On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> src/include/Makefile knows what it's supposed to install out
> of that subtree, and it thinks storage/*.h is sufficient.
> I didn't check to see if the meson system has the same oversight.
>
> One could argue that the real bug is having put a .c file into
> the include/ tree in the first place.  Why was it done like that?
> Couldn't it be a .h file?

That was the way it was first coded. I thought of this way to avoid
adding an exception to headerscheck. I can reverse that decision
easily, but I may not get to it today.

--
John Naylor
Amazon Web Services



pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install?
Next
From: Tom Lane
Date:
Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install?