Re: BUG #19450: Where is checksum_block.inc.c after master install? - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #19450: Where is checksum_block.inc.c after master install?
Date
Msg-id 1199322.1775444878@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #19450: Where is checksum_block.inc.c after master install?  (John Naylor <johncnaylorls@gmail.com>)
Responses Re: BUG #19450: Where is checksum_block.inc.c after master install?
List pgsql-bugs
John Naylor <johncnaylorls@gmail.com> writes:
> On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> One could argue that the real bug is having put a .c file into
>> the include/ tree in the first place.  Why was it done like that?
>> Couldn't it be a .h file?

> That was the way it was first coded. I thought of this way to avoid
> adding an exception to headerscheck. I can reverse that decision
> easily, but I may not get to it today.

Ah, the good ol' law of conservation of cruft.  But on the whole
I think naming it .h not .c is less crufty.  Agreed that there's
no great urgency about changing it.

            regards, tom lane



pgsql-bugs by date:

Previous
From: John Naylor
Date:
Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install?
Next
From: Dmytro Astapov
Date:
Subject: Re: array_agg(anyarray) silently produces corrupt results with parallel workers when inputs mix NULL and non-NULL array elements