Re: a couple of small patches for simd.h - Mailing list pgsql-hackers

From John Naylor
Subject Re: a couple of small patches for simd.h
Date
Msg-id CANWCAZaLyxDHoDFjvtaz0aM6Agx=P5i=0T8HnkgLNdwXwJn9Ug@mail.gmail.com
Whole thread Raw
In response to a couple of small patches for simd.h  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: a couple of small patches for simd.h
List pgsql-hackers
On Tue, Sep 23, 2025 at 4:44 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> 0001 essentially reverts commit c6a43c2, and instead fixes the problem
> (MSVC dislikes casts to the same type) by omitting the cast in the
> problematic line in pg_lfind32().  While working on optimizing hex_encode()
> and hex_decode() [0], I noticed that implicit conversions sufficed.

I don't remember why that cast was there, but I suggest testing on gcc
/ aarch64 if you haven't already.

As for 0002, +1 for more succinct expressions when the hardware supports it.

--
John Naylor
Amazon Web Services



pgsql-hackers by date:

Previous
From: Ajin Cherian
Date:
Subject: Re: Clear logical slot's 'synced' flag on promotion of standby
Next
From: Alexandra Wang
Date:
Subject: Re: SQL:2023 JSON simplified accessor support