Re: Clear logical slot's 'synced' flag on promotion of standby - Mailing list pgsql-hackers

From Ajin Cherian
Subject Re: Clear logical slot's 'synced' flag on promotion of standby
Date
Msg-id CAFPTHDa92MK6Y+LSf70QLtQwakqa3D9P2U+69WGQS2jhYzgYOQ@mail.gmail.com
Whole thread Raw
In response to Re: Clear logical slot's 'synced' flag on promotion of standby  (Ashutosh Sharma <ashu.coek88@gmail.com>)
List pgsql-hackers
On Tue, Sep 23, 2025 at 11:11 PM Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
>
> > 3)
> > + ereport(LOG,
> > + (errmsg("reset synced flag for replication slot \"%s\"",
> > + NameStr(s->data.name))));
> >
> > a) Shall we change it to DEBUG1?
> > b) Shall the msg be:
> > synced flag reset for replication slot \"%s\" during promotion
> >
>
> I think this can stay as a LOG message, it only runs once at startup
> and applies just to logical slots, so it won’t be noisy. I’d also
> avoid mentioning “during promotion,” since the flag might accidentally
> be set on the primary and then reset later during startup, making that
> description inaccurate.

Oops! that was actually leftover debug logs that I used in my testing
but I am happy to leave it as DEBUG1 or LOG1 as necessary.

regards,
Ajin Cherian
Fujitsu Australia



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
Next
From: John Naylor
Date:
Subject: Re: a couple of small patches for simd.h