Re: [HACKERS] Minor typo in partition.c - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: [HACKERS] Minor typo in partition.c
Date
Msg-id CANP8+jJpTBgf9XuD9GY1_v7NHDisH9fNrZDFBh3s9yraHX2ZOQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Minor typo in partition.c  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
On 14 April 2017 at 09:18, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:

>> Where shall I mention BRIN in that chapter?
>
> Maybe just append a new <sect2> right below where <sect2
> id="ddl-partitioning-constraint-exclusion"> ends?
>
> I had included both BRIN and UNION ALL views under a sub-section titled
> "Alternative Methods" in my original patch (March 3rd one), but removed
> the whole sub-section per review comments.  Perhaps, my patch didn't do a
> good enough job of describing either BRIN or UNION ALL views, that it
> ended up being not convincing enough to be made part of the section.
>
> By the way, will you also be adding details on UNION ALL views (I remember
> you said you would along with BRIN)?  Actually, my patch copied verbatim
> what older docs had about them that you said is too short a description.

It makes sense to describe all similar techniques in one section of the docs.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: [HACKERS] Minor typo in partition.c
Next
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] Cutting initdb's runtime (Perl question embedded)