Re: split func.sgml to separated individual sgml files - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: split func.sgml to separated individual sgml files
Date
Msg-id CAN55FZ1VSrhEWJcEyr_00MPW9BrkcztG+QmrU1-utwODzKJJ2g@mail.gmail.com
Whole thread Raw
In response to Re: split func.sgml to separated individual sgml files  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Hi,

On Thu, 2 Oct 2025 at 21:43, Andrew Dunstan <andrew@dunslane.net> wrote:
>
> On 2025-10-02 Th 8:52 AM, Nazir Bilal Yavuz wrote:
>
> I think there is one more problem that we need to think about. This
> test runs when the xmllint is enabled but it also requires docbook
> (docbook-xml on some OSes) to be installed, otherwise the test fails
> with 'I/O error : Attempt to load network entity
> http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd'. I think that
> we need to skip this test if the docbook can not be found in the
> system. Otherwise that would be a hassle for most of the people and
> buildfarm members. What do you think about this?
>
>
> Oops, missed seeing this earlier. Yes, I think we need to skip the test in the meson case. Probably nothing more
neededfor the Makefile.
 

Here is the patch which does that. It has a basic check for the
docbook and if the docbook can not be found, then meson skips the
test.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft

Attachment

pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Newly created replication slot may be invalidated by checkpoint
Next
From: Nazir Bilal Yavuz
Date:
Subject: Re: split func.sgml to separated individual sgml files