Request a Demo
Home   >   mailing lists

Re: Unused stricture field in xlogreader:DecodedBkpBlock - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: Unused stricture field in xlogreader:DecodedBkpBlock
Date
Msg-id CAN55FZ1+XtvaSLqSxRHUz=uw2StHwtM7mC6qdaYGewwzAAqcuA@mail.gmail.com
Whole thread Raw
In response to Unused stricture field in xlogreader:DecodedBkpBlock  (Mikhail Gribkov <youzhick@gmail.com>)
Responses Re: Unused stricture field in xlogreader:DecodedBkpBlock
List pgsql-hackers
Tree view 
Hi,

On Fri, 17 Oct 2025 at 14:37, Mikhail Gribkov <youzhick@gmail.com> wrote:
>
> Hi hackers,
>
> I found that DecodedBkpBlock.data_bufsz field in xlogreader.h is never ever used in the current code and not even
mentionedin any comments. It just occupies memory and removing it doesn't seem to break anything.
 
> Should we remove it maybe? Attached is the removal patch.

Thanks for the patch! It looks like it should have been removed in the
3f1ce97346.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft

pgsql-hackers by date:

Previous
From: Mikhail Gribkov
Date:
Subject: Unused stricture field in xlogreader:DecodedBkpBlock
Next
From: shveta malik
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart