Unused stricture field in xlogreader:DecodedBkpBlock - Mailing list pgsql-hackers

From Mikhail Gribkov
Subject Unused stricture field in xlogreader:DecodedBkpBlock
Date
Msg-id CAMEv5_sxuaiAfSy1ZyN=7UGbHg3C10cwHhEk8nXEjiCsBVs4vQ@mail.gmail.com
Whole thread Raw
Responses Re: Unused stricture field in xlogreader:DecodedBkpBlock
List pgsql-hackers
Hi hackers,

I found that DecodedBkpBlock.data_bufsz field in xlogreader.h is never ever used in the current code and not even mentioned in any comments. It just occupies memory and removing it doesn't seem to break anything.
Should we remove it maybe? Attached is the removal patch.
--
 best regards,
    Mikhail A. Gribkov

e-mail: youzhick@gmail.com
http://www.strava.com/athletes/5085772
phone: +7(916)604-71-12
Telegram: @youzhick

Attachment

pgsql-hackers by date:

Previous
From: Shubham Khanna
Date:
Subject: Re: Add support for specifying tables in pg_createsubscriber.
Next
From: Nazir Bilal Yavuz
Date:
Subject: Re: Unused stricture field in xlogreader:DecodedBkpBlock