Re: Trying out read streams in pgvector (an extension) - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: Trying out read streams in pgvector (an extension)
Date
Msg-id CAN55FZ0tgjF1beJSRXw3rgkbzwPZ7ngChJkPZm9aJkPuaF=dmg@mail.gmail.com
Whole thread Raw
In response to Re: Trying out read streams in pgvector (an extension)  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
Hi,

On Wed, 19 Nov 2025 at 00:17, Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> To make sure 1) distance isn't reset to a resume_distance from
> read_stream_begin_relation() and 2) unexpected buffers aren't returned
> from the read stream, we could error out in read_stream_resume() if
> pinned_buffers > 0. And in read_stream_reset(), we would save distance
> in resume_distance before clearing distance. That would allow calling
> read_stream_resume() either if you called read_stream_reset() or if
> you exhausted the stream yourself. See rough attached patch for a
> sketch of this.

This looks correct to me. What do you think about using an assert
instead of erroring out?

-- 
Regards,
Nazir Bilal Yavuz
Microsoft



pgsql-hackers by date:

Previous
From: David Geier
Date:
Subject: Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?
Next
From: jian he
Date:
Subject: Re: Extended Statistics set/restore/clear functions.