Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test
Date
Msg-id CAMsr+YHFFZnjDQ746QTzwy4me8S8fGM_99BSTmR=4zQHPF0TTw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regressiontest  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers


On 14 May 2017 11:33, "Robert Haas" <robertmhaas@gmail.com> wrote:
On Sat, May 13, 2017 at 6:22 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Or at least, that's what I surmise from the fact that buildfarm critter
> caiman has been failing that test for the last day or so, with symptoms
> indicating whitespace changes in Data::Dumper output.  Some poking into
> the Fedora repo shows that rawhide updated perl-Data-Dumper from 2.161
> to 2.167 on May 11, so that fits ...

Depending on the precise details of how Data::Dumper prints things
doesn't seem like a particularly good idea.

Surely Test::More::is_deeply is the way to go here.

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Hash Functions