Random PGDLLIMPORTing - Mailing list pgsql-hackers

From Craig Ringer
Subject Random PGDLLIMPORTing
Date
Msg-id CAMsr+YFcG_rj0gy-j-pUP-HqOK6hgM_uvEiPT9RdkT=vdh_25g@mail.gmail.com
Whole thread Raw
Responses Re: Random PGDLLIMPORTing  (Magnus Hagander <magnus@hagander.net>)
Re: Random PGDLLIMPORTing  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Hi all

Noticed this while reading something unrelated

extern PGDLLIMPORT pid_t PostmasterPid;
extern bool IsPostmasterEnvironment;
extern PGDLLIMPORT bool IsUnderPostmaster;
extern bool IsBackgroundWorker;
extern PGDLLIMPORT bool IsBinaryUpgrade;

I don't see any sane reason for some of those to be PGDLLIMPORT but
not others. In particular it's pretty silly for IsBackgroundWorker not
to be PGDLLIMPORT.

Too trivial to be worth making an actual patch, it'd be more work to
apply it than edit directly.

-- Craig Ringer                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: [PATCH] Reload SSL certificates on SIGHUP
Next
From: Magnus Hagander
Date:
Subject: Re: Random PGDLLIMPORTing