Re: Random PGDLLIMPORTing - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Random PGDLLIMPORTing
Date
Msg-id CABUevEy0qJv6xn0e9rG6iB2ZwEVoMfKdg_B+hMaiBzYDhW6p=Q@mail.gmail.com
Whole thread Raw
In response to Random PGDLLIMPORTing  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers


On Thu, Nov 24, 2016 at 2:58 PM, Craig Ringer <craig@2ndquadrant.com> wrote:
Hi all

Noticed this while reading something unrelated

extern PGDLLIMPORT pid_t PostmasterPid;
extern bool IsPostmasterEnvironment;
extern PGDLLIMPORT bool IsUnderPostmaster;
extern bool IsBackgroundWorker;
extern PGDLLIMPORT bool IsBinaryUpgrade;

I don't see any sane reason for some of those to be PGDLLIMPORT but
not others. In particular it's pretty silly for IsBackgroundWorker not
to be PGDLLIMPORT.

Too trivial to be worth making an actual patch, it'd be more work to
apply it than edit directly.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



--

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Random PGDLLIMPORTing
Next
From: Magnus Hagander
Date:
Subject: Re: Random PGDLLIMPORTing