Robert Haas <robertmhaas@gmail.com> writes: > Also, including the GID in the WAL for each COMMIT/ABORT PREPARED > doesn't seem inordinately expensive to me.
I'm confused ... isn't it there already? If not, how do we handle reconstructing 2PC state from WAL at all?
Right. Per my comments uothread I don't see why we need to add anything more to WAL here.
Stas was concerned about what happens in logical decoding if we crash between PREPSRE TRANSACTION and COMMIT PREPARED. But we'll always go back and decode the whole txn again anyway so it doesn't matter.
We can just track it on ReorderBufferTxn when we see it at PREPARE TRANSACTION time.
