Re: [PATCH] Fix disabled_nodes propagation for single-child Append paths - Mailing list pgsql-hackers

From Richard Guo
Subject Re: [PATCH] Fix disabled_nodes propagation for single-child Append paths
Date
Msg-id CAMbWs4_3xr5j8RzpB62g=5Emfvje9MQF8gWseszAgSucgj9EnQ@mail.gmail.com
Whole thread
Responses Re: [PATCH] Fix disabled_nodes propagation for single-child Append paths
List pgsql-hackers
On Thu, Aug 27, 2026 at 8:36 PM David Rowley <dgrowleyml@gmail.com> wrote:
> On Thu, 27 Aug 2026 at 19:36, Richard Guo <guofenglinux@gmail.com> wrote:
> > For the same reason as those commits, I'd also leave this master-only.
> > It is a v17 regression, but planner fixes risk destabilizing plans in
> > stable branches, and this doesn't seem severe enough to be an
> > exception.

> IMO, disabling a node type is quite a clear request that you only want
> that node type used if there's no alternative. I don't think the
> normal reasons for not wanting to destabilise plans here apply to
> this.

Makes sense.  I don't think anyone would get upset that we stopped
picking a plan containing a node they had disabled.

Maybe 47c110f77 and 6e466e1e8 should have been back-patched too?

Anyway, let's back-patch this one at least.

- Richard



Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: pg_plan_advice: fix empty FOREIGN_JOIN sublist validation
Next
From: shihao zhong
Date:
Subject: Re: [PATCH v1] amcheck: Allow interrupting the child-level rightlink walk