Request a Demo
Home   >   mailing lists

Re: [PATCH v1] amcheck: Allow interrupting the child-level rightlink walk - Mailing list pgsql-hackers

From shihao zhong
Subject Re: [PATCH v1] amcheck: Allow interrupting the child-level rightlink walk
Date
Msg-id CAGRkXqS=ocNby=vrwo4xjnFwTwNLtn_qnqDKCOQPdgx1oR8vrw@mail.gmail.com
Whole thread
In response to Re: [PATCH v1] amcheck: Allow interrupting the child-level rightlink walk  (김선동 <mok03127@gmail.com>)
Responses Re: RFC: Logging plan of the running query
List pgsql-hackers
Tree view 
On Sat, Jul 18, 2026 at 3:31 AM 김선동 <mok03127@gmail.com> wrote:
>>
>> Resending the v2 patch as an attachment so cfbot can pick it up — the earlier copies went inline. No changes to the
patchitself. 

Hi Paul,

Thanks for the patch -- I reviewed it and agree with your justification.
Every other page-traversal loop in verify_nbtree.c already has a
CHECK_FOR_INTERRUPTS(), and the rightlink walk in bt_child_highkey_check()
is the only one that was missing it, so this is a nice consistency fix on
top of the correctness argument you make in the commit message.

The placement is also safe, the function and loop doesn't hold a
buffer content lock
across iterations.

LGTM, I think this is good to go.

Thanks,
Shihao
Attachment

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: [PATCH] Fix disabled_nodes propagation for single-child Append paths
Next
From: shveta malik
Date:
Subject: Re: Publication of same parent table with ONLY-ness mismatch should error