Request a Demo
Home   >   mailing lists

Re: Wrong unsafe-flag test in check_output_expressions() - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Wrong unsafe-flag test in check_output_expressions()
Date
Msg-id CAMbWs48YpBiZdZiH6LSGCa6KY9qxd-kigwfV-QagMtCS_PtP7g@mail.gmail.com
Whole thread
In response to Re: Wrong unsafe-flag test in check_output_expressions()  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Jun 3, 2026 at 7:32 AM David Rowley <dgrowleyml@gmail.com> wrote:
> On Wed, 3 Jun 2026 at 10:13, Richard Guo <guofenglinux@gmail.com> wrote:
> > On Wed, Jun 3, 2026 at 5:59 AM David Rowley <dgrowleyml@gmail.com> wrote:
> > > Yes, that's not intentional. Your proposed fix looks correct. Are you
> > > happy to go ahead with pushing and backpatching that?

> > Thanks for taking a look.  Yeah, I'm happy to push that.  I'm kind of
> > unsure whether this needs to be back-patched, since it doesn't lead to
> > wrong plans, so it isn't a live bug in practice.

> I'd prefer it to be fully gone in all versions that have it, if you
> don't mind doing that.

Done.  Back-patched through v15, where the buggy check was first
introduced.

- Richard

pgsql-hackers by date:

Previous
From: Lukas Fittl
Date:
Subject: Re: Unify parallel worker handling for index builds and instrumentation
Next
From: Michael Paquier
Date:
Subject: Re: Unify parallel worker handling for index builds and instrumentation