Re: Wrong unsafe-flag test in check_output_expressions() - Mailing list pgsql-hackers

From David Rowley
Subject Re: Wrong unsafe-flag test in check_output_expressions()
Date
Msg-id CAApHDvokHMLg0-LBgdDRf_W-uBFNS-qs-cb+LDHXokUr3=9j8g@mail.gmail.com
Whole thread
In response to Re: Wrong unsafe-flag test in check_output_expressions()  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Wrong unsafe-flag test in check_output_expressions()
List pgsql-hackers
On Wed, 3 Jun 2026 at 10:13, Richard Guo <guofenglinux@gmail.com> wrote:
>
> On Wed, Jun 3, 2026 at 5:59 AM David Rowley <dgrowleyml@gmail.com> wrote:
> > Yes, that's not intentional. Your proposed fix looks correct. Are you
> > happy to go ahead with pushing and backpatching that?
>
> Thanks for taking a look.  Yeah, I'm happy to push that.  I'm kind of
> unsure whether this needs to be back-patched, since it doesn't lead to
> wrong plans, so it isn't a live bug in practice.

I'd prefer it to be fully gone in all versions that have it, if you
don't mind doing that.

David



pgsql-hackers by date:

Previous
From: Andrey Chernyy
Date:
Subject: Re: [PATCH] Fix libxml leaks in contrib/xml2 XPath functions
Next
From: David Rowley
Date:
Subject: Re: deep copy with mutation?