Re: making tid and HOTness of UPDATE available to logical decoding plugins - Mailing list pgsql-hackers

On Thu, Dec 4, 2025 at 11:35 PM Mihail Nikalayeu
<mihailnikalayeu@gmail.com> wrote:
>
> Hello!
>
> Thanks for the patch.

Thanks for reviewing :)

> Few comments:
>
> 1) tests are failing, expected output files need to be updated

Yes, I didn't want to start changing tests before other parts stabilized a bit.

> 2)
> > * Treat HOT update as normal updates. There is no useful
> > * information in the fact that we could make it a HOT update
> > * locally and the WAL layout is compatible.
>
> I think it feels a little bit irrelevant now. Also, I'll prefer to
> give XLOG_HEAP_HOT_UPDATE a dedicated case switch.

I added it after the comments about the need to track HOT in case we
would use it for collecting index entries.

As it is implemented now it should not affect any users who are not
interested in HOT.

> 3) _format_tid - not sure _ prefix is a good idea here, but not sure.

yeah, need to look around a little for established use in these parts
of the code.

> 4) new double newlines before and after _format_tid

ack


> 5)
>  > if (change->data.tp.newctid.ip_posid)
> Should we change it to
> if (ItemPointerIsValid(&change->data.tp.newctid))

I'll have to check. It looks likely that the whole check is redundant
and the tids are always available

> Best regards,
> Mikhail.