Request a Demo
Home   >   mailing lists

Re: making tid and HOTness of UPDATE available to logical decoding plugins - Mailing list pgsql-hackers

From Mihail Nikalayeu
Subject Re: making tid and HOTness of UPDATE available to logical decoding plugins
Date
Msg-id CADzfLwVqazjsPHgxuadvX0eW3MpByfRy9J4DWJ9goakp+G_sEA@mail.gmail.com
Whole thread Raw
In response to making tid and HOTness of UPDATE available to logical decoding plugins  (Hannu Krosing <hannuk@google.com>)
Responses Re: making tid and HOTness of UPDATE available to logical decoding plugins
List pgsql-hackers
Tree view 
Hello!

Thanks for the patch.

Few comments:

1) tests are failing, expected output files need to be updated

2)
> * Treat HOT update as normal updates. There is no useful
> * information in the fact that we could make it a HOT update
> * locally and the WAL layout is compatible.

I think it feels a little bit irrelevant now. Also, I'll prefer to
give XLOG_HEAP_HOT_UPDATE a dedicated case switch.

3) _format_tid - not sure _ prefix is a good idea here, but not sure.

4) new double newlines before and after _format_tid

5)
 > if (change->data.tp.newctid.ip_posid)
Should we change it to
if (ItemPointerIsValid(&change->data.tp.newctid))

Best regards,
Mikhail.

pgsql-hackers by date:

Previous
From: Paul A Jungwirth
Date:
Subject: Fix out-of-date comment on makeRangeConstructors
Next
From: Thomas Munro
Date:
Subject: Re: More const-marking cleanup