The latest patch looks good. By now doing a single scan of shmem two phase data, we have removed the double loops in all the affected functions which is good.
My only question is if the added call to restoreTwoPhaseData() is good enough to handle all the 3 functions PrescanPreparedTransactions(),StandbyRecoverPreparedTransactions() and RecoverPreparedTransactions() appropriately? It looks as if it does, but we need to be doubly sure..
PFA, revised patch with a very minor typo fix and rebase against latest master. The test cases pass as needed.
Oh, btw, while running TAP tests, I got a few errors in unrelated tests.
On Sun, Mar 26, 2017 at 4:50 PM, Nikhil Sontakke <nikhils@2ndquadrant.com> wrote: > I was away for a bit. I will take a look at this patch and get back to you > soon.
No problem. Thanks for your time! -- Michael
--
Nikhil Sontakke http://www.2ndQuadrant.com/ PostgreSQL/Postgres-XL Development, 24x7 Support, Training & Services
--
Nikhil Sontakke http://www.2ndQuadrant.com/ PostgreSQL/Postgres-XL Development, 24x7 Support, Training & Services