Postgres Pro
Downloads
Home   >   mailing lists

[pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server
Date
Msg-id CAM9w-_mrO59WXONZbjBfzv2LiYkzjaR2_MikWuVdUMJ=9YyNjg@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Re: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Hackers,

Attached is the patch to fix the issue mentioned in the subject.
Regarding hiding the color legend when the server is disconnected, I feel it's good to have the legend visible as it says it's a graph. Otherwise, a box with error is ambiguous. Plus, it's not going to change anyway even if graph data is available or not.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: Patch for SonarQube code scan fixes.
Next
From: Murtuza Zabuawala
Date:
Subject: Re: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server