Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection - Mailing list pgadmin-hackers

From Surinder Kumar
Subject Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection
Date
Msg-id CAM5-9D8apZstsBsk+dg7muOrmDX5vVU_DgDDDapO-kpnD7Yqyg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi

Please find updated patch.

On Thu, Sep 15, 2016 at 1:38 PM, Dave Page <dpage@pgadmin.org> wrote:
(pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM1579.patch
error: patch failed: web/pgadmin/static/css/overrides.css:53
error: web/pgadmin/static/css/overrides.css: patch does not apply

Please rebase!

On Thu, Sep 15, 2016 at 8:54 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Please find the attached patch patch with following changes:
>
> 1) Implemented CodeMirror addon 'simplescrollbars'.
>
> 2) The CodeMirror instance of query tool was not rendering into wcDocker's
> 'pg-panel-content' div. it renders outside the div, due to which it took
> little more time investigating why scrollbars doesn't appear in editor.
>
> 3) Add new css specific to query tool.
>
>
> Please review.
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix scrolling in the query tool editor. Fixes #1579