Fwd: [pgAdmin4][Patch]: Node issues under catalogs - Mailing list pgadmin-hackers

On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi

Following are the issues fixed in this patch:

1. Nodes not expanding under catalogs

Issue: Check for setting schema was missing. schema should set only if node is in create mode.

2. Error fetching node's properties.

Issue: Node attribute parent_type is not set to catalogs.

3. Don't show create rule option in table create menu if it is under catalog.

4. Security tab of node should be hidden under catalogs.

Every node with controls privilege and security labels must be under type: group

to keep them hide when node is listed under catalogs.

This code is implemented in backform.pgadmin.js

For Example:

schema:[{

    id: 'security', label: '{{ _("Security") }}',

    type: 'group'

},{

   id: 'acl', label: '{{ _('Privileges') }}', group: '{{ _('security') }}'

This is wrong - you should not put the group-id as i18n string.

It should be a simple string. i.e. group: 'security'

},{

  id: 'seclabels', label: '{{ _('Security Labels') }}', 

  model: SecurityModel, type: 'collection',

  group: '{{ _('security') }}'

Same as above.

}]

Please find attached patch and review.

I also found - we're not consistent about showing ACL on all the node.

For some node, we're not showing ACLs in properties mode.

Please send patch with above fixes.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi 

Thanks,

Surinder Kumar

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers