[pgAdmin4][Patch]: Node issues under catalogs - Mailing list pgadmin-hackers

From Surinder Kumar
Subject [pgAdmin4][Patch]: Node issues under catalogs
Date
Msg-id CAM5-9D_6mUo_gYJugiTYaXkR920-6YwJCAZAHAUc2e=CB12FqQ@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][Patch]: Node issues under catalogs
Re: [pgAdmin4][Patch]: Node issues under catalogs
List pgadmin-hackers
Hi

Following are the issues fixed in this patch:
1. Nodes not expanding under catalogs
Issue: Check for setting schema was missing. schema should set only if node is in create mode.

2. Error fetching node's properties.
Issue: Node attribute parent_type is not set to catalogs.

3. Don't show create rule option in table create menu if it is under catalog.

4. Security tab of node should be hidden under catalogs.
Every node with controls privilege and security labels must be under type: group
to keep them hide when node is listed under catalogs.
This code is implemented in backform.pgadmin.js

For Example:

schema:[{
    id: 'security', label: '{{ _("Security") }}',
    type: 'group'
},{
   id: 'acl', label: '{{ _('Privileges') }}', group: '{{ _('security') }}'
},{
  id: 'seclabels', label: '{{ _('Security Labels') }}', 
  model: SecurityModel, type: 'collection',
  group: '{{ _('security') }}'
}]

Please find attached patch and review.


Thanks,
Surinder Kumar
Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: [pgAdmin4][datagrid] : Fix URL generation issue in datagrid
Next
From: Susan Douglas
Date:
Subject: Documentation patch for pgAdmin 4