Re: Tuplesort merge pre-reading - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Tuplesort merge pre-reading
Date
Msg-id CAM3SWZTQtbDBGV5w5CkxokrPivvRmALmc9HMCP4wbu1AouiqFg@mail.gmail.com
Whole thread Raw
In response to Re: Tuplesort merge pre-reading  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
On Sun, Sep 11, 2016 at 3:13 PM, Peter Geoghegan <pg@heroku.com> wrote:
> * Please make this use the ".., + 1023" natural rounding trick that is
> used in the similar traces that are removed:
>
>> +#ifdef TRACE_SORT
>> +   if (trace_sort)
>> +       elog(LOG, "using %d kB of memory for read buffers in %d tapes, %d kB per tape",
>> +            (int) (state->availMem / 1024), maxTapes, (int) (per_tape * BLCKSZ) / 1024);
>> +#endif

Also, please remove the int cast, and use INT64_FORMAT. Again, this
should match existing trace_sort traces concerning batch memory.


-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Useless dependency assumption libxml2 -> libxslt in MSVC scripts
Next
From: Daniel Gustafsson
Date:
Subject: Typo in filename identification