Re: Commitfest problems - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Commitfest problems
Date
Msg-id CAM3SWZSmVQzXVgaCJJ25bD9UaAkEMPbLaVZcj_yskvO4YK_=1g@mail.gmail.com
Whole thread Raw
In response to Re: Commitfest problems  (Josh Berkus <josh@agliodbs.com>)
List pgsql-hackers
On Mon, Dec 15, 2014 at 11:52 AM, Josh Berkus <josh@agliodbs.com> wrote:
> On 12/15/2014 11:27 AM, Robert Haas wrote:
>> I feel like we used to be better at encouraging people to participate
>> in the CF even if they were not experts, and to do the best they can
>> based on what they did know.  That was a helpful dynamic.  Sure, the
>> reviews weren't perfect, but more people helped, and reviewing some of
>> the patch well and some of it in a more cursory manner is way better
>> than reviewing none of it at all.
>
> Well, it was strongly expressed to me by a number of senior contributors
> on this list and at the developer meeting that inexpert reviews were not
> really wanted, needed or helpful.  As such, I stopped recruiting new
> reviewers (and, for that matter, doing them myself).  I don't know if
> the same goes for anyone else.

Really? I thought we were pretty consistent in encouraging new reviewers.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: Commitfest problems
Next
From: Merlin Moncure
Date:
Subject: Re: [REVIEW] Re: Compression of full-page-writes