Re: Minor clarifying changes to abbreviated key abort code comments - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Minor clarifying changes to abbreviated key abort code comments
Date
Msg-id CAM3SWZS_mUTNnmBgaD5dXtt3VGLhWvPx1Q66N1EWWtP88_6w8g@mail.gmail.com
Whole thread Raw
In response to Re: Minor clarifying changes to abbreviated key abort code comments  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Minor clarifying changes to abbreviated key abort code comments
List pgsql-hackers
On Tue, Nov 3, 2015 at 5:47 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> This comment doesn't make sense to me:
>
> +                * (TSS_BUILDRUNS state prevents control reaching here in any
> +                * case).
>
> Unless I'm missing something, that's not actually true.

It is true.  consider_abort_common() only actually considers aborting
when state is TSS_INITIAL (we're still doing an internal sort). The
only other pertinent state here is TSS_BUILDRUNS. The point is that
TSS_BUILDRUNS is a generic "point of no return" past which
abbreviation cannot be aborted. That is a little arbitrary.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: fortnight interval support
Next
From: Robert Haas
Date:
Subject: Re: September 2015 Commitfest