Re: pg_get_viewdefs() indentation considered harmful - Mailing list pgsql-hackers

From Greg Stark
Subject Re: pg_get_viewdefs() indentation considered harmful
Date
Msg-id CAM-w4HM++8QW_dm3ovfC+CuibpbNHZYrgwJMqkgDUNOFNC-EOA@mail.gmail.com
Whole thread Raw
In response to Re: pg_get_viewdefs() indentation considered harmful  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Apr 30, 2014 at 6:47 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I pushed a patch that does it that way, and also patches for the other
> items discussed in this thread.

Great! thanks a lot. This makes a really solid noticeable difference
even in relatively simple cases and I know of users for whom this will
make a big difference.

That indentation code looks like a lot of work to maintain that I
hadn't really been aware of before. I wonder if there's some way to
combine it with the actual grammar so the input and output can be
edited in the same place.

-- 
greg



pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: GSoC on WAL-logging hash indexes
Next
From: Stephen Frost
Date:
Subject: Re: GSoC on WAL-logging hash indexes