Re: pg_get_viewdefs() indentation considered harmful - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_get_viewdefs() indentation considered harmful
Date
Msg-id 24649.1398880077@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_get_viewdefs() indentation considered harmful  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_get_viewdefs() indentation considered harmful  (Greg Stark <stark@mit.edu>)
Re: pg_get_viewdefs() indentation considered harmful  (Marko Tiikkaja <marko@joh.to>)
List pgsql-hackers
I wrote:
> I'm still dubious about halving the step distance, because there are
> assorted places that adjust the indentation of specific keywords by
> distances that aren't a multiple of 2 (look for odd last arguments to
> appendContextKeyword).  I'm not sure how that will look after we make such
> a change.  Possibly it would work to only apply the scale factor to
> context->indentLevel, and not the indentPlus number?

I pushed a patch that does it that way, and also patches for the other
items discussed in this thread.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: GSoC on WAL-logging hash indexes
Next
From: Tom Lane
Date:
Subject: Re: GSoC on WAL-logging hash indexes