Re: improve pg_receivewal code - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: improve pg_receivewal code
Date
Msg-id CALj2ACXV9EjvTUKrwaMBGMic7DiaaHwR2-yMWMKKGp7a6G=+jw@mail.gmail.com
Whole thread Raw
In response to Re: improve pg_receivewal code  (Michael Paquier <michael@paquier.xyz>)
Responses Re: improve pg_receivewal code  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu, Sep 16, 2021 at 9:31 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> > Here's the v2 with above modifications.
>
> I was looking at this patch, and I agree that checking for the system
> ID and the timeline by setting sysidentifier beforehand looks like an
> improvement.
>
> The extra IDENTIFY_SYSTEM done at the beginning of StreamLog() is not
> a performance bottleneck as we run it only once for each loop.  I
> don't really get the argument of a server replacing another one on the
> same port requiring to rely only on the first system ID fetched before
> starting the loops of StreamLog() calls.  So I would leave main()
> alone, but fill in the system ID from RunIdentifySystem() in
> StreamLog().

Thanks. I changed the code that way. PSA v3 patch.

Regards,
Bharath Rupireddy.

Attachment

pgsql-hackers by date:

Previous
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: [BUG] Unexpected action when publishing partition tables
Next
From: Amit Kapila
Date:
Subject: Re: POC: Cleaning up orphaned files using undo logs