Postgres Pro
Downloads
Home   >   mailing lists

Re: Move backup-related code to xlogbackup.c/.h - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Move backup-related code to xlogbackup.c/.h
Date
Msg-id CALj2ACW1D0H1Gmzwk4djMuVu9AJ0Q=ng0_o-v9E4hRpOOTz1Dg@mail.gmail.com
Whole thread Raw
In response to Re: Move backup-related code to xlogbackup.c/.h  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Move backup-related code to xlogbackup.c/.h  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Tree view 
On Wed, Oct 19, 2022 at 2:30 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> Another point before we move on with your 0002 is that forcePageWrites
> is no longer useful and we can remove it, as per the attached.

+1. The following comment enables us to rely on runningBackups and get
rid of forcePageWrites completely.

     * in progress. forcePageWrites is set to true when runningBackups is
     * non-zero. lastBackupStart is the latest checkpoint redo location used

When the standby is in recovery, calls to XLogInsertRecord() or
AdvanceXLInsertBuffer()) where forcePageWrites is being used, won't
happen, no?

      * Note that forcePageWrites has no effect during an online backup from
-     * the standby.
+     * the standby.   XXX what does this mean??

I removed the 2 more instances of forcePageWrites left-out and tweaked
the comments a little and attached 0002.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: make_ctags: use -I option to ignore pg_node_attr macro
Next
From: Yugo NAGATA
Date:
Subject: Re: make_ctags: use -I option to ignore pg_node_attr macro