Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages
Date
Msg-id CALj2ACVRUOGBCvVYBxnyrGA_fjbYJOb+N6Pn7rPqgN1QHsGxGQ@mail.gmail.com
Whole thread Raw
In response to Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
On Tue, Mar 1, 2022 at 6:50 AM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> At Mon, 28 Feb 2022 21:03:07 +0530, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote in
> > Hi,
> >
> > It looks like we use "log segment" in various user-facing messages.
> > The term "log" can mean server logs as well. The "WAL segment" suits
> > well here and it is consistently used across the other user-facing
> > messages [1].
> >
> > Here's a small patch attempting to consistently use the "WAL segment".
> >
> > Thoughts?
>
> I tend to agree to this.

Thanks for taking a look at it. Here's the CF entry -
https://commitfest.postgresql.org/38/3584/

> I also see "log record(s)" (without prefixed
> by "write-ahead") in many places especially in the documentation.  I'm
> not sure how we should treat "WAL log", though.

Yes, but the docs have a glossary term for 'Log record" [1]. FWIW
attaching docs change as v2-0002 patch. I found another place where
"log records" is being used in pg_waldump.c, I changed that and
attached v2-0001 patch.

Please review the v2 patch set.

[1]
 <glossentry id="glossary-log-record">
   <glossterm>Log record</glossterm>
    <glossdef>
     <para>
      Archaic term for a <glossterm linkend="glossary-wal-record">WAL
record</glossterm>.
     </para>
    </glossdef>
  </glossentry>

Regards,
Bharath Rupireddy.

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Add the replication origin name and commit-LSN to logical replication worker errcontext
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: more descriptive message for process termination due to max_slot_wal_keep_size