Postgres Pro
Downloads
Home   >   mailing lists

Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
Date
Msg-id CALj2ACUPpVw1u7sQocFVWrSs0n10pt_G_4NPZKSxXK6cW1dErw@mail.gmail.com
Whole thread Raw
Responses Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
List pgsql-hackers
Tree view 
Hi,

We have two static check_permissions functions (one in slotfuncs.c
another in logicalfuncs.c) with the same name and same code for
checking the privileges for using replication slots. Why can't we have
a single function CheckReplicationSlotPermissions in slot.c? This way,
we can get rid of redundant code. Attaching a patch for it.

Thoughts?

Regards,
Bharath Rupireddy.
Attachment

pgsql-hackers by date:

Previous
From: Jaime Casanova
Date:
Subject: Re: Polyphase merge is obsolete
Next
From: Andrey Borodin
Date:
Subject: Compressing temporary files