Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
Date
Msg-id 5b631883-a23a-458c-a8a3-63d344b0df7c@www.fastmail.com
Whole thread Raw
In response to Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
List pgsql-hackers
Tree view
On Sat, Sep 11, 2021, at 5:28 AM, Bharath Rupireddy wrote:
We have two static check_permissions functions (one in slotfuncs.c
another in logicalfuncs.c) with the same name and same code for
checking the privileges for using replication slots. Why can't we have
a single function CheckReplicationSlotPermissions in slot.c? This way,
we can get rid of redundant code. Attaching a patch for it.
Good catch! Your patch looks good to me.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

pgsql-hackers by date:

Previous
From: Jaime Casanova
Date:
Subject: Re: Schema variables - new implementation for Postgres 15
Next
From: Andrey Borodin
Date:
Subject: Re: Private Information Retrieval (PIR) as a C/C++ Aggregate Extension