Re: Proposal: Conflict log history table for Logical Replication - Mailing list pgsql-hackers

On Tue, 26 May 2026 at 15:08, shveta malik <shveta.malik@gmail.com> wrote:
>
> On Mon, May 25, 2026 at 10:13 AM vignesh C <vignesh21@gmail.com> wrote:
> >
> >
> > Thanks for the comments, the attached v39 version patch has the
> > changes for the same.
> >
>
> I have not yet looked at v40, but please find a few ocmments on
> v39-0001 and 0002 merged together.
> 4)
> Do we need to have CommandCounterIncrement() after
> heap_create_with_catalog() in create_conflict_log_table()? I think
> even if we are not doing any table_open etc for CLT in same
> transaction, we should call CommandCounterIncrement() (to be
> consistent with other such calls of heap_create_with_catalog and to
> make it future proof). Thoughts?

I felt this is not required as we are not doing a table open on the
newly created table.

I have fixed the rest of the comments. The attached v41 version patch
has the changes for the same.  Additionally the comments from [1] have
also been fixed.

[1] - https://www.postgresql.org/message-id/CAHut%2BPvB3rUs2ccUxJ1q1YEmvtHN3HJGSEjT4Cbc%3D5pjoGO9Yg%40mail.gmail.com

Regards,
Vignesh