Request a Demo
Home   >   mailing lists

Re: [PATCH] Release replication slot on error in SQL-callable slot functions - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [PATCH] Release replication slot on error in SQL-callable slot functions
Date
Msg-id CAHGQGwEoENMBTu0=f2h5_GFfTc-dGEo+_CfS0jinPwTX2AcyYA@mail.gmail.com
Whole thread
In response to Re: [PATCH] Release replication slot on error in SQL-callable slot functions  (SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>)
Responses Re: [PATCH] Release replication slot on error in SQL-callable slot functions
Re: [PATCH] Release replication slot on error in SQL-callable slot functions
List pgsql-hackers
Tree view 
On Wed, May 27, 2026 at 1:31 PM SATYANARAYANA NARLAPURAM
<satyanarlapuram@gmail.com> wrote:
> Thank you for the changes and review.

When I applied the v4 patch together with Shveta's diff patch and
ran the regression tests, the tests failed.

Could pg_create_physical_replication_slot() still have the same issue
if it throws an error after ReplicationSlotCreate() and that error is
caught by a PL/pgSQL EXCEPTION block?

Also, do maybe pg_copy_physical_replication_slot(), pg_drop_replication_slot(),
and ALTER_REPLICATION_SLOT potentially have the same issue as well?

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Adding REPACK [concurrently]
Next
From: vignesh C
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication