On Thu, 9 Jul 2026 at 07:07, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Some review comments for v8
>
> ======
> doc/src/sgml/ref/pg_createsubscriber.sgml
>
> 1.
> + which ensures each table is brought up to a synchronized state. When using
> + internally generated publications, the publications automatically include
> + all sequences in the database; however, sequence values are not
> + automatically synchronized.
>
> Maybe "automatically" 2x in the same sentence is a bit much. The rest
> can also be simpler.
>
> SUGGESTION
> Internally generated publications include all sequences in the
> database, but their values are not automatically synchronized.
>
> ~~~
>
> 2.
> + objects defined by that publication. Otherwise,
> + <application>pg_createsubscriber</application> creates a publication
> + using <link linkend="sql-createpublication-params-for-all-tables">
> + <literal>FOR ALL TABLES</literal></link> and <link
> + linkend="sql-createpublication-params-for-all-sequences"> <literal>ALL
> + SEQUENCES</literal></link>. These generated publications has the
> + following name pattern:
>
> 2a.
> The space before the last <literal> tag here is probably not deliberate.
>
> ~
>
> 2b.
> typo: /has the/have the/
Thanks for the comments, the attached v9 version patch has the changes
for the same.
Regards,
Vignesh
