Re: Include sequences in publications created by pg_createsubscriber - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Include sequences in publications created by pg_createsubscriber
Date
Msg-id CAHut+PsjAiTWT_tdUKHh0XBR=u1PwRxdYsRy2WLXQM6Ko3wgXg@mail.gmail.com
Whole thread
In response to Re: Include sequences in publications created by pg_createsubscriber  (vignesh C <vignesh21@gmail.com>)
Responses Re: Include sequences in publications created by pg_createsubscriber
List pgsql-hackers
Some review comments for v8

======
doc/src/sgml/ref/pg_createsubscriber.sgml

1.
+   which ensures each table is brought up to a synchronized state. When using
+   internally generated publications, the publications automatically include
+   all sequences in the database; however, sequence values are not
+   automatically synchronized.

Maybe "automatically" 2x in the same sentence is a bit much. The rest
can also be simpler.

SUGGESTION
Internally generated publications include all sequences in the
database, but their values are not automatically synchronized.

~~~

2.
+      objects defined by that publication. Otherwise,
+      <application>pg_createsubscriber</application> creates a publication
+      using <link linkend="sql-createpublication-params-for-all-tables">
+      <literal>FOR ALL TABLES</literal></link> and <link
+      linkend="sql-createpublication-params-for-all-sequences"> <literal>ALL
+      SEQUENCES</literal></link>. These generated publications has the
+      following name pattern:

2a.
The space before the last <literal> tag here is probably not deliberate.

~

2b.
typo: /has the/have the/

======
Kind Regards,
Peter Smith.
Fujitsu Australia



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Add enable_groupagg GUC parameter to control GroupAggregate usage
Next
From: jian he
Date:
Subject: Re: [PATCH] no table rewrite when set column type to constrained domain