Postgres Pro
Downloads
Home   >   mailing lists

Re: Add FOREIGN to ALTER TABLE in pg_dump - Mailing list pgsql-hackers

From vignesh C
Subject Re: Add FOREIGN to ALTER TABLE in pg_dump
Date
Msg-id CALDaNm0CQ5ASGSnipH-rnPg3W1zYzX+V7tK3DXexCd_7it+W6Q@mail.gmail.com
Whole thread Raw
In response to Re: Add FOREIGN to ALTER TABLE in pg_dump  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add FOREIGN to ALTER TABLE in pg_dump  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Mon, Jan 13, 2020 at 7:52 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> vignesh C <vignesh21@gmail.com> writes:
> > On Thu, Sep 26, 2019 at 7:17 PM Luis Carril <luis.carril@swarm64.com> wrote:
> >>> Your patch is failing the pg_dump TAP tests.  Please use
> >>> configure --enable-tap-tests, fix the problems, then resubmit.
>
> >> Fixed, I've attached a new version.
>
> > Will it be possible to add a test case for this, can we validate by
> > adding one test?
>
> Isn't the change in the TAP test output sufficient?
>

I could not see any expected file output changes in the patch. Should
we modify the existing test to validate this.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: DROP OWNED CASCADE vs Temp tables
Next
From: vignesh C
Date:
Subject: Re: Option to dump foreign data in pg_dump