Re: pg_publication_tables: return NULL attnames when no column list is specified - Mailing list pgsql-hackers

From Roberto Mello
Subject Re: pg_publication_tables: return NULL attnames when no column list is specified
Date
Msg-id CAKz==bKd4jdbMhp5AxSk6R9v1fUubceqoOQ-AGM93gFEdgNWEg@mail.gmail.com
Whole thread Raw
In response to Re: pg_publication_tables: return NULL attnames when no column list is specified  (Roberto Mello <roberto.mello@gmail.com>)
Responses Re: pg_publication_tables: return NULL attnames when no column list is specified
List pgsql-hackers
On Fri, Mar 27, 2026 at 11:27 AM Roberto Mello <roberto.mello@gmail.com> wrote:
On Thu, Mar 26, 2026 at 10:07 PM Ajin Cherian <itsajin@gmail.com> wrote:

One observation from reviewing the patch: the test suite covers the
partial column list and dropped column cases well, but is missing a
test for the two-publication conflict scenario (one pub with no list +
one pub with an explicit list of all columns on the same table). That
is the breaking change called out in the original report and probably
deserves its own regression test with a comment explaining the
expected behavior change for users in that configuration.
Patch LGTM otherwise.

Good point. I know I worked on that, so I must have accidentally dropped it from the patch.

Will prepare a revision and submit.

Here's v3 of the patch with the missing test.

Roberto Mello
Snowflake
Attachment

pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
Next
From: Andres Freund
Date:
Subject: Re: Buffer locking is special (hints, checksums, AIO writes)