Re: pg_publication_tables: return NULL attnames when no column list is specified - Mailing list pgsql-hackers

On Sat, Mar 28, 2026 at 6:54 AM Roberto Mello <roberto.mello@gmail.com> wrote:
>
> On Fri, Mar 27, 2026 at 11:27 AM Roberto Mello <roberto.mello@gmail.com> wrote:
>>
>> On Thu, Mar 26, 2026 at 10:07 PM Ajin Cherian <itsajin@gmail.com> wrote:
>>>
>>>
>>> One observation from reviewing the patch: the test suite covers the
>>> partial column list and dropped column cases well, but is missing a
>>> test for the two-publication conflict scenario (one pub with no list +
>>> one pub with an explicit list of all columns on the same table). That
>>> is the breaking change called out in the original report and probably
>>> deserves its own regression test with a comment explaining the
>>> expected behavior change for users in that configuration.
>>> Patch LGTM otherwise.
>>
>>
>> Good point. I know I worked on that, so I must have accidentally dropped it from the patch.
>>
>> Will prepare a revision and submit.
>
>
> Here's v3 of the patch with the missing test.

LGTM

regards,
Ajin Cherian
Fujitsu Australia