Re: IDLE in transaction introspection - Mailing list pgsql-hackers

From Scott Mead
Subject Re: IDLE in transaction introspection
Date
Msg-id CAKq0gvJDbQxcjN-euKLHYveghsu_=iQWtpz8sr7Fihhe0c_v_g@mail.gmail.com
Whole thread Raw
In response to Re: IDLE in transaction introspection  ("Albe Laurenz" <laurenz.albe@wien.gv.at>)
Responses Re: IDLE in transaction introspection
Re: IDLE in transaction introspection
Re: IDLE in transaction introspection
List pgsql-hackers
On Wed, Nov 2, 2011 at 4:12 AM, Albe Laurenz <laurenz.albe@wien.gv.at> wrote:
Andrew Dunstan wrote:
> On 11/01/2011 09:52 AM, Tom Lane wrote:
>> I'm for just redefining the query field as "current or last
>> query".
>
> +1
>
>> I could go either way on whether to rename it.
>
> Rename it please. "current_query" will just be wrong. I'd be inclined
> just to call it "query" or "query_string" and leave it to the docs to
> define the exact semantics.

+1 for renaming, +1 for a state column.
I think it is overkill to keep a query history beyond that -- if you
want that,
you can resort to the log files.


ISTM that we're all for:

   creating a new column: state
   renaming current_query => query 

   State will display <RUNNING>, <IDLE>, <IDLE> in transaction, etc... 
   query will display the last query that was executed.

I've written this up in the attached patch, looking for feedback. (NB: Originally I was using 9.1.1 release, I just did a git clone today to generate this).

--
  Scott Mead
   

 
Yours,
Laurenz Albe

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Single pass vacuum - take 2
Next
From: Robert Haas
Date:
Subject: Re: pg_upgrade if 'postgres' database is dropped