Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is incapital letters - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is incapital letters
Date
Msg-id CAKKotZS=MGh8dNOXNnrW7aVOeywqfG_gnma1E=aByM5SeAriKQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is incapital letters  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is incapital letters  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
List pgadmin-hackers
Hi,

PFA updated patch, which includes feature test to test the scenario going forward.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Feb 15, 2018 at 7:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
​Sure, will do that.​

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Feb 15, 2018 at 7:34 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Murtuza,
Just reviewed your patch, and it looks good. 
Do you think you can wrap some tests around this behavior to ensure it doesn't happen again in the future?

Thanks
Joao

On Thu, Feb 15, 2018 at 8:34 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue user was not able to insert new row in the table via 'view data' if the PK is in capital letters.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Attachment

pgadmin-hackers by date:

Previous
From: Joao De Almeida Pereira
Date:
Subject: Re: [pgAdmin4][RM#2950] Add marker to dashboard queries
Next
From: Joao De Almeida Pereira
Date:
Subject: Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is incapital letters